E2e protocol ricardo #1826
Merged
E2e protocol ricardo #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoeffect
reviewed
Jan 29, 2024
shared/domains/chelonia/chelonia.js
Outdated
Comment on lines
1240
to
1249
| return { | ||
| get serialize () { | ||
| return () => { | ||
| if (instance !== self._instance) throw new Error('Chelonia instance has been reset') | ||
| const rootState = sbp(self.config.stateSelector) | ||
| const height = String(rootState.contracts[contractID].height) | ||
| return { ...message.serialize(height), height } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If .serialize() is called immediately, and we don't need this outer wrapper object, can we just immediately return line 1246?
Passing run #1839 ↗︎
Details:
Review all test suite changes for PR #1826 ↗︎ |
|||||||||||||||
taoeffect
reviewed
Jan 29, 2024
| sbp('gi.actions/chatroom/user-typing-event', { | ||
| contractID: this.currentChatRoomId | ||
| }).catch(e => { | ||
| console.info('Error emitting user typing event', e) |
There was a problem hiding this comment.
console.error or console.warn
taoeffect
reviewed
Jan 29, 2024
| sbp('gi.actions/chatroom/user-stop-typing-event', { | ||
| contractID: this.currentChatRoomId | ||
| }).catch(e => { | ||
| console.info('Error emitting user stopped typing event', e) |
There was a problem hiding this comment.
console.error or console.warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.